improved error message when expected type cannot be calculated

fixes #779
wurstscript · Dec 22, 2018 · 8383632 · 8383632
1 parent 11662b9
commit 8383632
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/de.peeeq.wurstscript/src/main/java/de/peeeq/wurstscript/attributes/AttrExprExpectedType.java b/de.peeeq.wurstscript/src/main/java/de/peeeq/wurstscript/attributes/AttrExprExpectedType.java
@@ -3,6 +3,7 @@
 import de.peeeq.wurstscript.WLogger;
 import de.peeeq.wurstscript.ast.*;
 import de.peeeq.wurstscript.types.*;
+import de.peeeq.wurstscript.utils.Utils;
 
 import java.util.Collection;
 
@@ -90,12 +91,12 @@ public static WurstType calculate(Expr expr) {
                     return m.attrFunctionSignature().getReceiverType();
                 }
             }
-        } catch (
-                CompileError t)
-
-        {
+        } catch (CyclicDependencyError | CompileError t) {
+            WLogger.info("Something went wrong while computing the expected type for " + Utils.printElementWithSource(expr) + "\n" +
+                    "This is probably not a bug, but we are logging it anyway since it might help to improve error messages.");
             WLogger.info(t);
         }
+
         return WurstTypeUnknown.instance();
     }
 

diff --git a/de.peeeq.wurstscript/src/main/java/de/peeeq/wurstscript/attributes/AttrExprType.java b/de.peeeq.wurstscript/src/main/java/de/peeeq/wurstscript/attributes/AttrExprType.java
@@ -554,7 +554,7 @@ public static WurstType calculate(ExprMemberMethodDotDot e) {
 
     public static WurstType calculate(ExprEmpty e) {
         e.addError("Missing expression");
-        return new WurstTypeUnknown("empty expression");
+        return new WurstTypeUnknown("empty");
     }
 
     public static WurstType calculate(ExprIfElse e) {