Merge pull request #96 from viniciusnz/master

Allow no CVV in credit card payments
wvanbergen · Oct 21, 2014 · 82b0803 · 82b0803
2 parents 35b01b9 + bd146ea
commit 82b0803
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/lib/adyen/api/payment_service.rb b/lib/adyen/api/payment_service.rb
@@ -174,9 +174,10 @@ def card_partial
         if @params[:card] && @params[:card][:encrypted] && @params[:card][:encrypted][:json]
           ENCRYPTED_CARD_PARTIAL % [@params[:card][:encrypted][:json]]
         else
-          validate_parameters!(:card => [:holder_name, :number, :cvc, :expiry_year, :expiry_month])
-          card  = @params[:card].values_at(:holder_name, :number, :cvc, :expiry_year)
+          validate_parameters!(:card => [:holder_name, :number, :expiry_year, :expiry_month])
+          card  = @params[:card].values_at(:holder_name, :number, :expiry_year)
           card << @params[:card][:expiry_month].to_i
+          card << (['', nil].include?(@params[:card][:cvc]) ? '' : (CARD_CVC_PARTIAL % @params[:card][:cvc]))
           CARD_PARTIAL % card
         end
       end

diff --git a/lib/adyen/api/templates/payment_service.rb b/lib/adyen/api/templates/payment_service.rb
@@ -59,12 +59,17 @@ def modification_request_with_amount(method)
         <payment:card>
           <payment:holderName>%s</payment:holderName>
           <payment:number>%s</payment:number>
-          <payment:cvc>%s</payment:cvc>
           <payment:expiryYear>%s</payment:expiryYear>
           <payment:expiryMonth>%02d</payment:expiryMonth>
+          %s
         </payment:card>
       EOXML
 
+      # @private
+      CARD_CVC_PARTIAL = <<-EOXML
+        <payment:cvc>%s</payment:cvc>
+      EOXML
+
       # @private
       ONE_CLICK_CARD_PARTIAL = <<-EOXML
         <payment:card>

diff --git a/spec/api/payment_service_spec.rb b/spec/api/payment_service_spec.rb
@@ -121,7 +121,7 @@
     it_should_validate_request_parameters :merchant_account,
                                           :reference,
                                           :amount => [:currency, :value],
-                                          :card => [:holder_name, :number, :cvc, :expiry_year, :expiry_month]
+                                          :card => [:holder_name, :number, :expiry_year, :expiry_month]
 
     it_should_validate_request_param(:shopper) do
       @payment.params[:recurring] = true