Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/full wildcard support #68

Merged
merged 11 commits into from
Jun 10, 2019

Conversation

Chuckame
Copy link
Contributor

Hi.

Actually, wildcards are not fully supported.

My proposition:

  • Add groupId wildcard support.
  • Remove regex on artifactId, use only wildcards (the same in regex: .*).
  • Change wildcard operation to use * every where in groupId or artifactId like :
    • my.group* (takes my.group, my.group-extension, my.group.subgroup, ...)
    • my*artifact (takes myartifact, mysuperlongartifact, ...)
    • myproject-* (takes myproject-libs, myproject-components, ...)
    • * (takes all)

Fix bug:

@wvengen
Copy link
Owner

wvengen commented May 24, 2018

Thanks for your contribution! This is quite a big change, @cmorty would you like to review?

@FibreFoX
Copy link
Collaborator

@wvengen yes, will do after some last personal things related to GDPR ;) probably next sunday

@Chuckame
Copy link
Contributor Author

@wvengen Can you merge this request and create a release ?

@cjgriscom
Copy link
Contributor

I've encountered this too and this PR seems to fix the issue. Is there anything else to be done?

@lasselindqvist
Copy link
Collaborator

@Chuckame would it be possible to add some example usages to the documentation (index.apt)?
I also resolved the conflicts that appeared from previous merged pull request. Could you confirm that the conflict resolution was correct?

@cjgriscom
Copy link
Contributor

cjgriscom commented Jun 3, 2019

@lasselindqvist I added some here: https://github.com/cjgriscom/proguard-maven-plugin/tree/feature/full-wildcard-support

I can also confirm that the plugin works correctly for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants