info: only resolve workspaceIdentity, workspaceProject as needed #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added partial typing information. This is just a start to allow more easily navigating the code with a type-aware IDE. After adding some typing info, resolve related errors as reported by pyright.
The plugins' implementation of these methods could be somewhat expensive, so we don't want to, for example, call workspaceProject() each time a JobInfo is initialized as part of reading a job entry from the database. To address this, we call resolve() to resolve the attributes' values in only two instances: 1. when the job is created (but not yet started), and 2. when the job is started. For the case of (2), `resolve(force=True)` is used so that we override the creation values in case something has changed in the environment that might affect these values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugins' implementation of these methods could be somewhat expensive, so we don't
want to, for example, call workspaceProject() each time a JobInfo is initialized as
part of reading a job entry from the database.
To address this, we call resolve() to resolve the attributes' values in only two
instances:
For the case of (2),
resolve(force=True)is used so that we override the creationvalues in case something has changed in the environment that might affect these values.