Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

info: only resolve workspaceIdentity, workspaceProject as needed #161

Merged
merged 2 commits into from
Feb 8, 2022
Merged

info: only resolve workspaceIdentity, workspaceProject as needed #161

merged 2 commits into from
Feb 8, 2022

Commits on Feb 8, 2022

  1. misc: add partial typing information to .info 

    Added partial typing information. This is just a start to allow more easily
navigating the code with a type-aware IDE.

After adding some typing info, resolve related errors as reported by pyright.
    @wwade
    wwade committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    539d38f View commit details
    Browse the repository at this point in the history

  2. info: only resolve workspaceIdentity, workspaceProject as needed 

    The plugins' implementation of these methods could be somewhat expensive, so we don't
want to, for example, call workspaceProject() each time a JobInfo is initialized as
part of reading a job entry from the database.

To address this, we call resolve() to resolve the attributes' values in only two
instances:
  1. when the job is created (but not yet started), and
  2. when the job is started.

For the case of (2), `resolve(force=True)` is used so that we override the creation
values in case something has changed in the environment that might affect these values.
    @wwade
    wwade committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    7ffe4be View commit details
    Browse the repository at this point in the history