Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding section regarding commit message format to CONTRIBUTING.md. #106

Merged
merged 4 commits into from
Aug 13, 2021
Merged

Adding section regarding commit message format to CONTRIBUTING.md. #106

merged 4 commits into from
Aug 13, 2021

Conversation

morganzellers
Copy link
Contributor

@morganzellers morganzellers commented Aug 11, 2021 •
edited by Tyler-Keith-Thompson

Checklist:

@morganzellers morganzellers added the documentation Improvements or additions to documentation label Aug 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021 •
edited

Codecov Report

Merging #106 (547501a) into main (082b711) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files          65       65           
  Lines        1680     1680           
=======================================
  Hits         1593     1593           
  Misses         87       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af30af...547501a. Read the comment docs.

@morganzellers morganzellers marked this pull request as ready for review August 11, 2021 20:17
@morganzellers morganzellers requested a review from a team as a code owner August 11, 2021 20:17
Richard-Gist
Richard-Gist approved these changes Aug 13, 2021
View reviewed changes
Copy link
Collaborator

@Richard-Gist Richard-Gist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @wiemerm resolve their conversation, but this looks good to me.

@morganzellers morganzellers merged commit bc49f54 into main Aug 13, 2021
@morganzellers morganzellers deleted the commit-message-style branch August 13, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiemerm wiemerm wiemerm left review comments

@Tyler-Keith-Thompson Tyler-Keith-Thompson Tyler-Keith-Thompson left review comments

@brianlombardo brianlombardo brianlombardo approved these changes

@Richard-Gist Richard-Gist Richard-Gist approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@morganzellers @codecov-commenter @brianlombardo @wiemerm @Tyler-Keith-Thompson @Richard-Gist