Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Working with Modals.md #141

Merged
merged 1 commit into from Sep 16, 2021
Merged

Update Working with Modals.md #141

merged 1 commit into from Sep 16, 2021

Conversation

courtneybeisner
Copy link
Contributor

@courtneybeisner courtneybeisner commented Sep 16, 2021

Proofread and made changes.

Linked Issue:

Checklist:


If Applicable:

  • Did you test when the first item is skipped?
  • Did you test when the last item is skipped?
  • Did you test when middle items are skipped?
  • Did you test when incorrect data is passed forward?
  • Did you test proceeding backwards?

If Public API Has Changed:

  • Did you deprecate (rather than remove) any old methods/variables/etc? Our philosophy for deprecation.
  • Have you done the best that you can to make sure that the compiler guides people to changing to the new API? (Example: the renamed attribute)
  • If necessary, have you tested the upgrade path for at least N-1 versions? For example, if data persists between v1 and v2 then that upgrade should be tested and as easy as we can make it.

Proofread and made changes.
@courtneybeisner courtneybeisner added the documentation Improvements or additions to documentation label Sep 16, 2021
@courtneybeisner courtneybeisner requested a review from a team as a code owner September 16, 2021 18:14
@codecov-commenter
Copy link

Codecov Report

Merging #141 (5a1e348) into main (4238248) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files          81       81           
  Lines        2096     2096           
=======================================
  Hits         1915     1915           
  Misses        181      181           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da6c83...5a1e348. Read the comment docs.

@Richard-Gist Richard-Gist merged commit 08460a3 into main Sep 16, 2021
@Richard-Gist Richard-Gist deleted the courtneybeisner-patch-8 branch September 16, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants