Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue where skipping views with a NavigationStack or Modal presentation style didn't work correctly with SwiftUI #210

Merged
merged 6 commits into from Aug 13, 2022

Conversation

Tyler-Keith-Thompson
Copy link
Collaborator

@Tyler-Keith-Thompson Tyler-Keith-Thompson commented Aug 13, 2022

Linked Issue: #209

Checklist:


If Applicable:

  • Did you test when the first item is skipped?
  • Did you test when the last item is skipped?
  • Did you test when middle items are skipped?
  • Did you test when incorrect data is passed forward?
  • Did you test proceeding backwards?

@Tyler-Keith-Thompson Tyler-Keith-Thompson added the bug Something isn't working label Aug 13, 2022
@Tyler-Keith-Thompson Tyler-Keith-Thompson requested a review from a team as a code owner August 13, 2022 20:17
@Tyler-Keith-Thompson
Copy link
Collaborator Author

I'm gonna go ahead and merge, however the tests didn't catch this issue and I'm really not certain why. I'll poke around at them after prod is back up and running.

@Tyler-Keith-Thompson Tyler-Keith-Thompson merged commit 2cebe59 into main Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant