-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: navigate to an empty view under conditional flow #209
Labels
bug
Something isn't working
Comments
I'll look into reproducing this, while I do is your |
No. I didn't embed them in a navigation view. And this issue could also be reproduced with a modal presentation. BTW, Just now I tried with ver4.5.24 and everything is going fine.
获取 Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
发件人: Tyler Thompson ***@***.***>
发送时间: Monday, August 1, 2022 1:41:39 PM
收件人: wwt/SwiftCurrent ***@***.***>
抄送: dulllight ***@***.***>; Author ***@***.***>
主题: Re: [wwt/SwiftCurrent] [Bug]: navigate to an empty view under conditional flow (Issue #209)
I'll look into reproducing this, while I do is your WorkflowView inside a NavigationView?
―
Reply to this email directly, view it on GitHub<#209 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAIWIA3QYGVZSC7PBMUZIGLVW5PRHANCNFSM55GCDKCQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I was able to reproduce the issue. I'll look into a fix, but I'm posting the reproduction in case somebody else can get to it faster. |
Tyler-Keith-Thompson
added a commit
that referenced
this issue
Aug 2, 2022
Thanks for the confirmation.
获取 Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
发件人: Tyler Thompson ***@***.***>
发送时间: Tuesday, August 2, 2022 5:14:47 AM
收件人: wwt/SwiftCurrent ***@***.***>
抄送: dulllight ***@***.***>; Author ***@***.***>
主题: Re: [wwt/SwiftCurrent] [Bug]: navigate to an empty view under conditional flow (Issue #209)
SCRepro.zip<https://github.com/wwt/SwiftCurrent/files/9237451/SCRepro.zip>
I was able to reproduce the issue. I'll look into a fix, but I'm posting the reproduction in case somebody else can get to it faster.
―
Reply to this email directly, view it on GitHub<#209 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAIWIAZU36UYJ5MSZVAOITLVXA44PANCNFSM55GCDKCQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Alright! The branch fix-209 has the correct behavior. I still need to get tests updated and fix a couple pipeline things before I can release. |
Fixed in 5.1.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Navigate to an empty view under conditional flow with presentation type of navigationLink
Hi, Today I notice a strange behavior. In screen A, there is a toggle. If toggle is on, press "Next", it would lead to screen B. If off, to screen C. If the presentationTyp is navigationLink or modal, when toggle is off, if press "Next", it would not lead to screen C
but an empty view. Would you please help check what might cause this issue? Many thanks.
Version
SwiftCurrent 5.1.5
Xcode 13.3.1
Relevant code sample
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: