Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HyperTreeList text search only works once #1293

Open
cbeytas opened this issue Jul 3, 2019 · 0 comments · May be fixed by #2088
Open

HyperTreeList text search only works once #1293

cbeytas opened this issue Jul 3, 2019 · 0 comments · May be fixed by #2088

Comments

@cbeytas
Copy link
Contributor

cbeytas commented Jul 3, 2019

wxPython 4.0.3
Text typed into a HyperTreeList searches for a matching item, but it only works once.
The text (self._findPrefix) never gets reset by self._findTimer, which never gets started.

The search logic in the customtreectrl.py base class starts self._findTimer only if it evaluates False:

                if not self._findTimer:
                    self._findTimer = TreeFindTimer(self)

The __init__() method of HyperTreeList sets self._findTimer to a wx.Timer() instance so the timer is never started.

        self._findTimer = wx.Timer(self)

If this line is commented out or removed self._findTimer will get initialized to None by the customtreectrl init and everything works fine.

cbeytas added a commit to cbeytas/Phoenix that referenced this issue Jan 23, 2022
Fixes wxWidgets#2083, wxWidgets#2081, wxWidgets#1981, wxWidgets#1938, wxWidgets#1901, wxWidgets#1898, wxWidgets#1880, wxWidgets#1293
Runs 10-100x faster while using slightly more memory.
Adds a new style `TR_LIVE_UPDATE` to show column resizing live rather than drawing a preview line.
Bump version from 1.4 to 1.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant