Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes in wx.lib.calendar #1234

Merged
merged 11 commits into from May 29, 2019
Merged

Various fixes in wx.lib.calendar #1234

merged 11 commits into from May 29, 2019

Conversation

ricpol
Copy link
Contributor

@ricpol ricpol commented May 25, 2019

Fixes #1230

  • wx.lib.calendar does not need wx.lib.CDate anymore. We just use datetime.date and wx.DateTime for all our needs;
  • fixed a bug with key navigation across month boundaries;
  • key navigation works fine now, setting the date and firing the EVT_CALENDAR;
  • setter APIs works fine now, setting the date in a "smart" way (eg, automatically shifting the day when moving to a month with fewer days);
  • a lot of fixes to wx.lib.calendar.CalendDlg, to make it work in the updated context;
  • wx.lib.CDate should not be needed anymore and can be removed: however it is fixed now (the old py2 division operator caused rounding errors in py3);
  • added/updated tests for both modules.

I tried to be as light-handed as possible, preserving the existing APIs. However there are still many annoyances and inconsistencies... In the long run a more in-depth rewrite would be required I think.

Copy link
Member

@RobinD42 RobinD42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a bullet item in CHANGES.rst in the 4.1.0 section about this change. Just a sentence to two can suffice.

@RobinD42 RobinD42 merged commit 56e6bd4 into wxWidgets:master May 29, 2019
RobinD42 added a commit that referenced this pull request Sep 14, 2019
Various fixes in wx.lib.calendar

(cherry picked from commit 56e6bd4)
@RobinD42 RobinD42 mentioned this pull request Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The buggy state of wx.lib.calendar
2 participants