Activate double-click processor only if wxPGComboBox editor is associ…

…ated with wxBoolProperty. Special handling of double-clicks (in wxPGDoubleClickProcessor) makes sense only for properties handling Boolean values (wxBoolProperty).
wxWidgets · Feb 26, 2015 · b5e0a16 · b5e0a16
1 parent fe7afd2
commit b5e0a16
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/src/propgrid/editors.cpp b/src/propgrid/editors.cpp
@@ -522,6 +522,9 @@ class wxPGDoubleClickProcessor : public wxEvtHandler
     wxPGDoubleClickProcessor( wxOwnerDrawnComboBox* combo, wxPGProperty* property )
         : wxEvtHandler()
     {
+        wxASSERT_MSG( wxDynamicCast(property, wxBoolProperty),
+           wxT("Double-click processor should be used only with wxBoolProperty") );
+
         m_timeLastMouseUp = 0;
         m_combo = combo;
         m_property = property;
@@ -536,7 +539,6 @@ class wxPGDoubleClickProcessor : public wxEvtHandler
         int evtType = event.GetEventType();
 
         if ( m_property->HasFlag(wxPG_PROP_USE_DCC) &&
-             wxDynamicCast(m_property, wxBoolProperty) &&
              !m_combo->IsPopupShown() )
         {
             // Just check that it is in the text area
@@ -640,10 +642,14 @@ class wxPGComboBox : public wxOwnerDrawnComboBox
                                             name ) )
             return false;
 
-        m_dclickProcessor = new
-            wxPGDoubleClickProcessor( this, GetGrid()->GetSelection() );
-
-        PushEventHandler(m_dclickProcessor);
+        // Enabling double-click processor makes sense
+        // only for wxBoolProperty.
+        wxPGProperty* selProp = GetGrid()->GetSelection();
+        if (wxDynamicCast(selProp, wxBoolProperty))
+        {
+            m_dclickProcessor = new wxPGDoubleClickProcessor(this, selProp);
+            PushEventHandler(m_dclickProcessor);
+        }
 
         return true;
     }