Fix wxGrid colours #2378
Merged
Fix wxGrid colours #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes of 3c28244 (Improve wxGrid appearance in dark mode under macOS, 2020-08-07) resulted in using white highlight colour over white background under at least MSW and probably elsewhere, making the grid cursor invisible by default. Fix this by using wxSYS_COLOUR_WINDOWTEXT which must contrast with wxSYS_COLOUR_WINDOW used for the background colour.
This was also changed in 3c28244 (Improve wxGrid appearance in dark mode under macOS, 2020-08-07) but there doesn't appear to be any good reason to do it as wxSYS_COLOUR_3DDKSHADOW is the same as the previously used wxSYS_COLOUR_3DSHADOW (a.k.a. wxSYS_COLOUR_BTNSHADOW) under Mac, so this didn't change anything there -- but did make the shadows darker and hence more pronounced and more noticeable under MSW. Undo this change to restore the old and nicer looking appearance.
No real changes, just make it more obvious that wxSYS_COLOUR_BTNSHADOW and wxSYS_COLOUR_3DDKSHADOW are mapped to the same colour under Mac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore wxGrid cursor visibility broken in 3.1.5 by #2026.