Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unified memory #1

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Remove unified memory #1

wants to merge 15 commits into from

Conversation

wxj6000
Copy link
Owner

@wxj6000 wxj6000 commented Aug 22, 2024

No description provided.

@wxj6000
Copy link
Owner Author

wxj6000 commented Aug 23, 2024

@susilehtola This PR tries to remove the usage of unified memory in libxc. I made this changes for two reasons

  • Unified memory is not support by all the CUDA platforms. Some platforms such as windows/WSL or hypervisor disable certain or all supports of unified memory. That leads to unexpected errors.
  • Unified memory introduces significant overhead.

Here are the related issues in GPU4PySCF
pyscf/gpu4pyscf#195
pyscf/gpu4pyscf#188
and possibly related issues in libxc
https://gitlab.com/libxc/libxc/-/issues/474
https://gitlab.com/libxc/libxc/-/issues/438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants