-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Configure dev server port with dev.server.port
#577
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for the PR! But I forgot, it's not that easy lol...
All config is merged and default values are applied inside Let me refactor a little and break that loop, and I'll commit my changes to this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
==========================================
+ Coverage 86.22% 86.38% +0.15%
==========================================
Files 111 111
Lines 8909 8937 +28
Branches 886 892 +6
==========================================
+ Hits 7682 7720 +38
+ Misses 1213 1203 -10
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Alright, fixed that issue and merged your PR with the latest. I ended up putting the config under |
dev.server.port
Added the
dev.port
field toInlineConfig
to allow configuring the dev server port.