Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor order of config resolution #578

Merged
merged 5 commits into from
Mar 29, 2024

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Mar 29, 2024

See #577 (comment). Now config is always resolved immediately at the beginning of all public APIs.

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit c07e996
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/66064f261fa70000089ba323
😎 Deploy Preview https://deploy-preview-578--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 88.63636% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 86.21%. Comparing base (448436c) to head (c07e996).
Report is 2 commits behind head on main.

Files Patch % Lines
src/core/create-server.ts 79.31% 12 Missing ⚠️
src/core/utils/building/resolve-config.ts 88.88% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
- Coverage   86.36%   86.21%   -0.15%     
==========================================
  Files         111      111              
  Lines        8888     8909      +21     
  Branches      879      887       +8     
==========================================
+ Hits         7676     7681       +5     
- Misses       1198     1214      +16     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 marked this pull request as ready for review March 29, 2024 05:20
@aklinker1 aklinker1 merged commit c9c5d72 into main Mar 29, 2024
15 checks passed
@aklinker1 aklinker1 deleted the resolve-config-order-refactor branch March 29, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant