This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Upgrading to Rails 5 post #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Therefore: | ||
|
|
||
| - We substitute the minitest-capybara for the minitest-rails-capybara entry | ||
| - We call a require of `capybara/rails` in place of `minitest/rails/capybara` in the `test_helper.rb`. |
There was a problem hiding this comment.
I don't think We call a require is a valid expression in this context.
What about the following?
"We require capybara/rails in place of minitest/rails/capybara in the test_helper.rb"
|
|
||
| Within the new initializers, `config/initializers/active_record_belongs_to_required_by_default.rb` is added, which makes it so that the belongs_to cannot be nil. In our case, we need some to be nil, so we have to add the option `optional: true` to the relations. For example, `belongs_to :category, optional: true`. | ||
|
|
||
| Also, config/initializers/callback_terminator.rb is added, which makes it so that the callbacks do not halt more when a false is returned. The way to halt now is with `throw(:abort)`. In our application, this was irrelevant. |
There was a problem hiding this comment.
this was irrelevant => this was irrelevant and had no effect or just had no effect
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.