Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override dataclass constructor to improve performance #295

Merged
merged 3 commits into from
Dec 29, 2021

Conversation

wyfo
Copy link
Owner

@wyfo wyfo commented Dec 29, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #295 (c2c4aee) into master (4e19709) will increase coverage by 0.06%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
+ Coverage   85.48%   85.55%   +0.06%     
==========================================
  Files          65       65              
  Lines        5609     5654      +45     
  Branches     1153     1167      +14     
==========================================
+ Hits         4795     4837      +42     
  Misses        598      598              
- Partials      216      219       +3     
Impacted Files Coverage Δ
apischema/deserialization/methods.py 85.10% <93.02%> (+0.44%) ⬆️
apischema/deserialization/__init__.py 98.87% <100.00%> (+0.02%) ⬆️
apischema/settings.py 91.66% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e19709...c2c4aee. Read the comment docs.

@wyfo wyfo merged commit a4fba7a into master Dec 29, 2021
@wyfo wyfo deleted the override_dataclasses_constructor branch December 29, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants