This repository has been archived by the owner on Apr 2, 2021. It is now read-only.
Less global pollution #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Included requirements | ||
| ===================== | ||
| Global Pollution | ||
| ================ |
There was a problem hiding this comment.
Included requirements is not main enough for the readme. What is required here is global pollution.
There was a problem hiding this comment.
Agreed. If they care about libraries we use, they can check out package.json
Merged
| window.ObjectHistory = require("object-history/history"); | ||
| WYMeditor.EXTERNAL_MODULES = { | ||
| ObjectHistory: require("object-history/history") | ||
| }; |
There was a problem hiding this comment.
Renamed this file because it doesn't globalify any more.
There was a problem hiding this comment.
Instead, it creates and populates WYMeditor.EXTERNAL_MODULES.
|
Looks good. 👍 |
winhamwr
added a commit
that referenced
this pull request
Dec 12, 2014
Closes #638 Less global pollution
|
Thank you!!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.