This repository has been archived by the owner on Apr 2, 2021. It is now read-only.
Image resizing #747
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,7 +51,7 @@ | |
| "jquery" : true, | ||
|
|
||
| "nomen" : false, | ||
| "onevar" : false, | ||
| "passfail" : false, | ||
| "white" : true, | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| /* jshint maxlen: 100 */ | ||
| /* global | ||
| manipulationTestHelper, | ||
| prepareUnitTestModule, | ||
| skipKeyboardShortcutTests, | ||
| SKIP_THIS_TEST, | ||
| test, | ||
| expectOneMore, | ||
| simulateKeyCombo, | ||
| stop, | ||
| start, | ||
| strictEqual, | ||
| ok, | ||
| IMG_SRC | ||
| */ | ||
| 'use strict'; | ||
|
|
||
| module("images-resize_handle", {setup: prepareUnitTestModule}); | ||
|
|
||
| test("Resize handle is prepended to body on image `mousemove`", function () { | ||
| manipulationTestHelper({ | ||
| startHtml: '<p><img src="' + IMG_SRC + '" /></p>', | ||
| manipulationFunc: function (wymeditor) { | ||
| wymeditor.$body().find('img').mousemove(); | ||
| }, | ||
| additionalAssertionsFunc: function (wymeditor) { | ||
| var $resizeHandle = wymeditor.$body().children().first(); | ||
| expectOneMore(); | ||
| ok($resizeHandle.hasClass('wym-resize-handle')); | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| test("image marker is immediately after image", function () { | ||
| manipulationTestHelper({ | ||
| startHtml: '<p><img src="' + IMG_SRC + '" /></p>', | ||
| manipulationFunc: function (wymeditor) { | ||
| wymeditor.$body().find('img').mousemove(); | ||
| }, | ||
| additionalAssertionsFunc: function (wymeditor) { | ||
| expectOneMore(); | ||
| var $imgMarker = wymeditor.$body().find('.wym-image-marker'); | ||
| ok($imgMarker.prev('img').length); | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| test("resize handle has editor-only class", function () { | ||
| manipulationTestHelper({ | ||
| startHtml: '<p><img src="' + IMG_SRC + '" /></p>', | ||
| manipulationFunc: function (wymeditor) { | ||
| wymeditor.$body().find('img').mousemove(); | ||
| }, | ||
| additionalAssertionsFunc: function (wymeditor) { | ||
| var $resizeHandle = wymeditor.$body().find('.wym-resize-handle'); | ||
| expectOneMore(); | ||
| ok($resizeHandle.hasClass('wym-editor-only')); | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| test("resize handle hidden on `mousemove` outside image and handle", function () { | ||
| manipulationTestHelper({ | ||
| startHtml: '<p><img src="' + IMG_SRC + '" /></p>', | ||
| manipulationFunc: function (wymeditor) { | ||
| wymeditor.$body().find('img') | ||
| .mousemove() | ||
| .parent().mousemove(); | ||
| }, | ||
| additionalAssertionsFunc: function (wymeditor) { | ||
| expectOneMore(); | ||
| strictEqual(wymeditor.$body().find('.wym-resize-handle').css('display'), 'none'); | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| test("resize handle not hidden on `mousemove` over handle", function () { | ||
| manipulationTestHelper({ | ||
| startHtml: '<p><img src="' + IMG_SRC + '" /></p>', | ||
| manipulationFunc: function (wymeditor) { | ||
| wymeditor.$body().find('img').mousemove(); | ||
| wymeditor.$body().find('.wym-resize-handle').mousemove(); | ||
| }, | ||
| additionalAssertionsFunc: function (wymeditor) { | ||
| expectOneMore(); | ||
| strictEqual(wymeditor.$body().find('.wym-resize-handle').css('display'), 'block'); | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| test("resize handle with no image is hidden async after 'keypress'", function () { | ||
| manipulationTestHelper({ | ||
| startHtml: '<p><img src="' + IMG_SRC + '" /></p>', | ||
| setCaretInSelector: 'p', | ||
| manipulationFunc: function (wymeditor) { | ||
| wymeditor.$body().find('img').mousemove().remove(); | ||
| simulateKeyCombo(wymeditor, 'a'); | ||
| }, | ||
| additionalAssertionsFunc: function (wymeditor) { | ||
| expectOneMore(); | ||
| stop(); | ||
| setTimeout(function () { | ||
| start(); | ||
| strictEqual(wymeditor.$body().find('.wym-resize-handle').css('display'), 'none'); | ||
| }, 0); | ||
| }, | ||
| skipFunc: function () { | ||
| if (skipKeyboardShortcutTests) { | ||
| return SKIP_THIS_TEST; | ||
| } | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| test("resize handle with no image is hidden on `mousemove`", function () { | ||
| manipulationTestHelper({ | ||
| startHtml: '<p><img src="' + IMG_SRC + '" /></p>', | ||
| manipulationFunc: function (wymeditor) { | ||
| wymeditor.$body().find('img') | ||
| .mousemove() | ||
| .remove(); | ||
| wymeditor.$body().find('.wym-resize-handle').mousemove(); | ||
| }, | ||
| additionalAssertionsFunc: function (wymeditor) { | ||
| expectOneMore(); | ||
| strictEqual(wymeditor.$body().find('.wym-resize-handle').css('display'), 'none'); | ||
| } | ||
| }); | ||
| }); | ||
|
There was a problem hiding this comment. There can be many more tests, but this is good enough for the benefit we're getting. |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blah. I don't like this style and it was removed in JSHint. Notice you can't find it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I 💟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol...of course there's already a fork with semicolons :p