This repository has been archived by the owner on Apr 2, 2021. It is now read-only.
Can't select text with mouse drag (in master) #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doh. Thanks for catching this before it went live. |
| // default action for this event may be a `mousedown` and `mousemove` | ||
| // with the intention to select text | ||
| // or to drag (for later dropping of) content | ||
| // so be careful about preventing default |
There was a problem hiding this comment.
This is the culprit.
Now it returns false only when it is surely not a text selection attempt.
There was a problem hiding this comment.
I should have looked closer at where these handlers were actually being bound. good thing you played with the editor
|
👍 |
mightyiam
added a commit
that referenced
this pull request
Oct 29, 2015
Can't select text with mouse drag (in master)
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most likely from #747's
mousedownhandler.