Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format with google-java-format #7

Closed
YikSanChan opened this issue Oct 5, 2020 · 2 comments
Closed

Format with google-java-format #7

YikSanChan opened this issue Oct 5, 2020 · 2 comments

Comments

@YikSanChan
Copy link
Contributor

YikSanChan commented Oct 5, 2020

The code format is a little bit off. Will you consider formatting the code base with https://github.com/google/google-java-format, and furthermore make it part of the build process? This way no code without being properly formatted can be checked in.

@wzhe06
Copy link
Owner

wzhe06 commented Oct 5, 2020

This is a good point for sure. While SparrowRecSys in this stage is mainly for beginners' practicing and more modules and languages may be added to this project meanwhile. Let's do stricter format check after all main modules has been added. And I will transfer the project to a formal open source project by then. Thx.

@YikSanChan
Copy link
Contributor Author

YikSanChan commented Oct 5, 2020 via email

@wzhe06 wzhe06 closed this as completed Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants