You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code format is a little bit off. Will you consider formatting the code base with https://github.com/google/google-java-format, and furthermore make it part of the build process? This way no code without being properly formatted can be checked in.
The text was updated successfully, but these errors were encountered:
This is a good point for sure. While SparrowRecSys in this stage is mainly for beginners' practicing and more modules and languages may be added to this project meanwhile. Let's do stricter format check after all main modules has been added. And I will transfer the project to a formal open source project by then. Thx.
This is a good point for sure. While SparrowRecSys in this stage is mainly
for beginners' practicing and more modules and languages may be added to
this project meanwhile. Let's do stricter format check after all main
modules has been added. And I will transfer the project to a formal open
source project by then. Thx.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEDOKNIY3MCULZKP2NOPVS3SJFWW5ANCNFSM4SEIBCKQ>
.
The code format is a little bit off. Will you consider formatting the code base with https://github.com/google/google-java-format, and furthermore make it part of the build process? This way no code without being properly formatted can be checked in.
The text was updated successfully, but these errors were encountered: