fix toNumber #57

x-extends · Nov 5, 2023 · 070eaa9 · 070eaa9
1 parent a47bd0c
commit 070eaa9
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/func/helperCreateToNumber.js b/func/helperCreateToNumber.js
@@ -1,7 +1,7 @@
 function helperCreateToNumber (handle) {
   return function (str) {
     if (str) {
-      var num = handle(str)
+      var num = handle(str && str.replace ? str.replace(/,/g, '') : str)
       if (!isNaN(num)) {
         return num
       }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "xe-utils",
-  "version": "3.5.13",
+  "version": "3.5.14",
   "description": "JavaScript 函数库、工具类",
   "main": "index.js",
   "unpkg": "dist/xe-utils.umd.min.js",

diff --git a/test/number.test.js b/test/number.test.js
@@ -797,6 +797,9 @@ describe('Number functions', () => {
     expect(
       XEUtils.toNumberString('123.33')
     ).toEqual('123.33')
+    expect(
+      XEUtils.toNumberString('12,345.33')
+    ).toEqual('12,345.33')
     expect(
       XEUtils.toNumberString(1e-9)
     ).toEqual('0.000000001')
@@ -875,6 +878,15 @@ describe('Number functions', () => {
     expect(
       XEUtils.toNumber('12.3')
     ).toEqual(12.3)
+    expect(
+      XEUtils.toNumber('12,345')
+    ).toEqual(12345)
+    expect(
+      XEUtils.toNumber('12,345.33')
+    ).toEqual(12345.33)
+    expect(
+      XEUtils.toNumber('12,345,678.33')
+    ).toEqual(12345678.33)
     expect(
       XEUtils.toNumber('12456456.66663')
     ).toEqual(12456456.66663)