-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start now button: Incorrect name? #137
Comments
Arguably it could be an option passed to the Trade-offs between more closely following the |
I did a quick GitHub search to see if the component was in use anywhere and there are a few - I'll hold off the renaming until the next major version and leave this issue as a reminder. |
In theory we shouldn't be using the Start now button in services, as it should only be on GOV.UK start pages... ;-) |
It'll now be known as the StartButtonComponent which is more in line with the design system. Due to the extra complexity of it containing an SVG it'll remain a separate component for the time being (vs making it an extension of the #govuk_link_to helper). Fixes #137
Now this is really pernickety, but… what’s called the ‘Start now button’ component in this gem, is commonly referred to as the ‘Start button’. See: https://design-system.service.gov.uk/components/button/#start-buttons (Also, the class is
govuk-button--start
).Suppose it’s too late to rename this component… or at least until there’s a breaking change?
The text was updated successfully, but these errors were encountered: