Version 2.0.0 #158
Merged
Version 2.0.0 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.0.0 tabs
…g-text Version 2.0.0 tag and warning text
Replace Accordion with new AccordionComponent
Also move this assertation over to RSpec HTML matcher syntax
…-breadcrumbs Update the back link and breadcrumb components
- Upgrade to the new slots API - Update specs to be consistent and use have_tag matcher
…anner Version 2.0.0 Notification Banner
…d-of-ugly-selectors Favour the with syntax over long complex selectors
- Remove template and use call method to render - Rename arguments for consistency with design system - Update spec to use with syntax
- Update specs to use with syntax
- Use call method for rendering panel component - Update spec to use with syntax
Version 2.0.0 InsetTextComponent
Rewrite the cookie banner with slots
Update the demo page
…tions-specs Split actions specs so extra classes aren't needed
…ew-component Bump to latest version of ViewComponent
…e-banner-heading Add 'govuk-heading-m' to cookie banner message h2
Some services might want to display the row in the summary list despite it having no content.
Don't error when summary list value is empty
…okie-banner-grid Move button group out of cookie banner message grid
…n-and-visually-hidden-text Ensure there's a space before visually hidden text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewComponent has progressed significantly since this library was created. Due to our use of the old slot API, significant changes are required to bring it in line with the latest version. It's impossible to simply adjust our existing slots so they work with slots v2.
This is a good opportunity to tighten things up a bit and improve consistency throughout.
Style choices
tag/content_taghelpers and pass arrays of classes instead of building the string inside templates#callComponent updates
Nice-to-haves
Improve the guide/docs. Perhaps create a statically-built guide like the form builder's (also create a PR to update the ViewComponent page that lists us if we change the URL)going to push this back to2.1.0, probably a couple of weeks' work here at leastHousekeeping
govuk-rubocop >= 4.0.0