Give accordion feature parity with nunjucks macros #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a heading_html slot to the accordion section that takes a block of HTML. If both heading_text and heading_html are supplied the HTML will take precedence. If neither are supplied an error will be raised. To ease the process of testing the accordion has been split out into a separate file; I repeatedly ran into problems getting the tests to work when the accordion and section components shared a single file[0]. A lambda slot was used because ideally we want to specify the heading level for each section once in the accordion; it wouldn't be ideal to have to do it once-per-section. Lambda slots are the only style that support sharing values between the parent and child. [0] ViewComponent/view_component#1000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
titletoheading_textheading_htmlslot to sectionsummarytosummary_textsummary_htmlslot to sectionI have not added a
textargument to section as raw text can always be passed into the block to form the content.Refs #202