-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support same name repository #14
Conversation
gofmt please? (and then the last blank line should be removed) |
I don't think we should support paths starting with "/" (e.g. "/ruby" expands to "https://github.com/ruby/ruby). You can fail with error or leave the behavior undefined in that case. |
Oh, I'm sorry. fix it soon. |
@motemen Fixed. Please review again. Thank you for your mention of paths starting with "/". I decided to avoid "/ruby" case. Current behavior |
} | ||
isSSH := c.Bool("p") | ||
if isSSH { | ||
fmt.Println(url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debugging line remained?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very very sorry..
refs #4 |
Thanks 😄 |
Support same name repository, closes #4
Thank you for your patient review. my PR is badly made... 🙇 |
Support same name repository like Bundler. (see also: http://bundler.io/v1.6/git.html)
We can
ghq get ruby
then clonehttps://github.com/ruby/ruby
now.(I'm sorry for new last line...)
Do I support
/ruby
?