Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to build against ffmpeg 5.0 #8

Closed
dvzrv opened this issue Jan 24, 2022 · 4 comments
Closed

Unable to build against ffmpeg 5.0 #8

dvzrv opened this issue Jan 24, 2022 · 4 comments

Comments

@dvzrv
Copy link
Contributor

dvzrv commented Jan 24, 2022

Hi! We're currently rebuilding packages against ffmpeg 5.0.

Unfortunately this does not work with harvid. I can provide a patch for some of the easier deprecations and changes to ffmpeg over the past five years, but the changes to AVPicture are a bit above my pay grade:

https://ffmpeg.org/doxygen/4.0/group__lavc__picture.html
https://ffmpeg.org/doxygen/4.0/group__lavu__picture.html#ga5b6ead346a70342ae8a303c16d2b3629

It would be really cool if you could provide a fix for this, as I don't know how to do it :-/
@dvzrv dvzrv mentioned this issue Jan 24, 2022
Merged
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Feb 3, 2022
@dvzrv
upgpkg: harvid 0.8.3-3: Rebuild against ffmpeg4.4.
aacad23 
The package is not compatible with ffmpeg >= 5
x42/harvid#8

Simplify quoting in file.
Simplify calls to make.
Replace custom patch for libjpeg-turbo detection with upstream patch.

git-svn-id: file:///srv/repos/svn-community/svn@1124908 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Feb 3, 2022
@dvzrv
upgpkg: harvid 0.8.3-3: Rebuild against ffmpeg4.4.
4f277aa 
The package is not compatible with ffmpeg >= 5
x42/harvid#8

Simplify quoting in file.
Simplify calls to make.
Replace custom patch for libjpeg-turbo detection with upstream patch.

git-svn-id: file:///srv/repos/svn-community/svn@1124908 9fca08f4-af9d-4005-b8df-a31f2cc04f65
This was referenced Feb 3, 2022
Merged
Closed
@thesamesam
Copy link

This looks fixed in 0.9.0 by 8d10c61 (and some other commits). You may want 5da512c too.

@dvzrv
Copy link
Contributor Author

dvzrv commented Jul 26, 2022

Yes, 0.9.0 is in the repos already (archlinux/svntogit-community@8fa61a3).
I didn't need the 2nd commit you mentioned though. @x42 is this producing crashes during runtime without? If so, maybe 0.9.1 could be a good idea :)

@thesamesam
Copy link

The second commit was needed for me w/ <ffmpeg-5 I think. So may not be needed for you.

@x42
Copy link
Owner

x42 commented Jul 26, 2022

@thesamesam is correct, the latter commit is required for backwards compatibility only.
I'm sorry I should have written a better commit message.

I trust this issue can be closed then?

@x42 x42 closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@x42 @dvzrv @thesamesam