Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build against ffmpeg >= 5 #50

Closed
dvzrv opened this issue Feb 3, 2022 · 3 comments
Closed

Unable to build against ffmpeg >= 5 #50

dvzrv opened this issue Feb 3, 2022 · 3 comments

Comments

@dvzrv
Copy link
Contributor

dvzrv commented Feb 3, 2022

Hi! Similar to the issues with harvid (x42/harvid#8) I am also unable to build xjadeo against ffmpeg >= 5.
I was able to (partially) fix some of the deprecations in #49 but I am stuck with the same issue in regards to AVPicture (after applying the patches from the aforementioned PR):

xjadeo.c:444:34: error: ‘AVPicture’ undeclared (first use in this function); did you mean ‘AVPictureType’?
  444 |                 avpicture_fill ((AVPicture *)pFrameFMT, buffer, render_fmt, movie_width, movie_height);
      |                                  ^~~~~~~~~
      |                                  AVPictureType
xjadeo.c:444:34: note: each undeclared identifier is reported only once for each function it appears in
xjadeo.c:444:45: error: expected expression before ‘)’ token
  444 |                 avpicture_fill ((AVPicture *)pFrameFMT, buffer, render_fmt, movie_width, movie_height);
      |                                             ^

Full build log: xjadeo-0.8.10-build.log

archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Feb 3, 2022
The package is not compatible with ffmpeg >= 5
x42/xjadeo#50

Simplify quoting in file.
Add debug package.

git-svn-id: file:///srv/repos/svn-community/svn@1124916 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Feb 3, 2022
The package is not compatible with ffmpeg >= 5
x42/xjadeo#50

Simplify quoting in file.
Add debug package.

git-svn-id: file:///srv/repos/svn-community/svn@1124916 9fca08f4-af9d-4005-b8df-a31f2cc04f65
@x42
Copy link
Owner

x42 commented Feb 4, 2022

Can you try to replace the line with

av_image_fill_arrays (pFrameFMT->data, pFrameFMT->linesize, buffer, render_fmt, movie_width, movie_height, 0);

@x42
Copy link
Owner

x42 commented Feb 4, 2022

Should be fixed since 9f62448

@x42 x42 closed this as completed Feb 4, 2022
@dvzrv
Copy link
Contributor Author

dvzrv commented Feb 4, 2022

Hm, I don't think so.

You merged #49 a bit too fast. As mentioned in #49 (comment) that commit does not work as intended (it does not build with it) and I wanted to find a better fix for it. Sorry, if that was not clear :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants