Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow in thread view and rename a thread from call stack view #3232

Open
torusrxxx opened this issue Oct 3, 2023 · 4 comments
Open

Follow in thread view and rename a thread from call stack view #3232

torusrxxx opened this issue Oct 3, 2023 · 4 comments
Labels
enhancement The issue requests an enhancement to an existing feature. good first issue The issue has a limited scope and is good for new developers. gui The issue is about the GUI of x64dbg.

Comments

@torusrxxx
Copy link
Member

Call stack view shows an overview of what each thread is doing. However users can't name a thread from there. The thread names are also not shown in call stack view.
Sometimes there are too many threads created by the system. The user should be able to mark these threads as system threads and then hide them.
@torusrxxx torusrxxx added enhancement The issue requests an enhancement to an existing feature. gui The issue is about the GUI of x64dbg. good first issue The issue has a limited scope and is good for new developers. labels Oct 3, 2023
@tusharv01
Copy link

If you have a specific thread or context in which you'd like to discuss naming threads or handling system threads, please provide more details, and I'll do my best to assist you.

@torusrxxx
Copy link
Member Author

torusrxxx commented Oct 7, 2023 •
edited

3232
The relevant code is in \src\gui\Src\Gui\CallStackView.cpp

tusharv01 added a commit to tusharv01/x64dbg that referenced this issue Oct 7, 2023
@tusharv01
Update CallStackView.cpp
6ba61b4 
issue x64dbg#3232
@tusharv01 tusharv01 mentioned this issue Oct 7, 2023
Closed
@torusrxxx
Copy link
Member Author

I think a better first step would be adding "follow in threads view" here.

@torusrxxx torusrxxx changed the title Name a thread from call stack view Follow in thread view and rename a thread from call stack view Oct 17, 2023
@foralost
Copy link
Contributor

So:

  1. Adding a thread name on horizontal line near the number of the thread (if defined).
  2. Adding an option to the right mouse button menu while in Call Stack view:
    • Follow in Thread View
    • Rename Thread

right?

@foralost foralost mentioned this issue Oct 30, 2023
Merged
mrexodia added a commit that referenced this issue Nov 18, 2023
@mrexodia
Merge pull request #3262 from foralost/3232-follow_rename_thread_call…
a320227 
…stack

#3232: Providing Rename Thread and etc. for CallStack View
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue requests an enhancement to an existing feature. good first issue The issue has a limited scope and is good for new developers. gui The issue is about the GUI of x64dbg.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@torusrxxx @foralost @tusharv01