Introduced dump to trace

[torusrxxx]

This fixes #2378
There's obviously a lot more to do. This pull request is here only for those who desperately want to dump from a trace or want to become alpha testers.
Right click on an instruction in the trace, and click the "Information" menu to get full dump of the trace up to the selected instruction into the log view.

[torusrxxx]

The trace dump index is working and tested on a 136MB huge trace.
Speed is lightening. Search constant takes 10 seconds and memory reference search takes 46ms. When memory reference search is used for the first time it takes 17s including reading the trace file and building the index.
Memory usage is moderate. It saves a record in trace for every byte, so memory usage could be improved by saving a record for every dword instead. This is more complex due to special treatment needed for unaligned memory access. Currently it uses about 567MB for the 136MB test trace, may be acceptable.
Next step will be the GUI part.

[mrexodia]

Would you like this to be merged into development or will you continue development on this branch? Currently the format checks are failing, so merging is blocked...

[torusrxxx]

I think those new files are already formatted, no idea why appveyor doesn't like that. I'll pause development for a while, but I don't think this feature is completed. The aim of this pull request is to bring in dump and stack windows, not to merely accelerate memory reference search. Of course I support merging it if you think merging this would allow other people to use this feature and contribute to it. Possibly disable the debug feature of dumping the trace memory in log view when clicking on "information" menu, it should be available in the dump tab instead.

[torusrxxx]

Dump widget has been added to trace, now it looks almost like the CPU view. There are still tons of usability problems and random crashes.

[mrexodia]

It looks like this is conflicting with the changes in #3192 a bit. I will try to properly refactor the HexDump to take an AbstractMemoryPage with pure virtual read/write functions, since this will be useful for other projects as well.

[mrexodia]

The following files are causing the formatting checks error btw:

src/gui/Src/Tracer/TraceDump.cpp
src/gui/Src/Tracer/TraceDump.h
src/gui/Src/Tracer/TraceFileDump.cpp
src/gui/Src/Tracer/TraceFileDump.h

Might be CRLF vs LF?

[AppVeyorBot]

✅ Download x64dbg 1.0.1711 (commit ab2a69cd13 by @torusrxxx)

[AppVeyorBot]

✅ Download x64dbg 1.0.1725 (commit 3d0e2654a9 by @torusrxxx)

[torusrxxx]

Maybe refactor HexDump first, and then we continue from that?

[AppVeyorBot]

✅ Download x64dbg 1.0.1726 (commit f02671aeb3 by @torusrxxx)

[mrexodia]

🥳 will give it a try ASAP!

[AppVeyorBot]

✅ Download x64dbg 1.0.1867 (commit 40e9c822bf by @torusrxxx)

[AppVeyorBot]

✅ Download x64dbg 1.0.1870 (commit a3a59e37b1 by @torusrxxx)

[torusrxxx]

Xrefs dialog is added so you can quickly find out what accessed this memory location. Extremely easy and fast.

[AppVeyorBot]

✅ Download x64dbg 1.0.1871 (commit b12e9ee114 by @torusrxxx)

[AppVeyorBot]

✅ Download x64dbg 1.0.1873 (commit 0a1fb28928 by @torusrxxx)

[torusrxxx]

This was waiting for review for a very long time. What do you think about this?

[mrexodia]

Yeah I've been busy recently, just got around to doing some x64dbg maintenance today. The changes look good to me, but I think the disabling functionality could be better.

For me the ideal user experience would be:

• Disable the trace dump per default
• Whenever the user triggers an action that requires it, build the dump
• Allow enabling per default

This way no resources are consumed when it's not needed. But if you don't have time to implement this I will take a look at it later and we can just merge it as-is.

[torusrxxx]

Ok, I'm going to improve that soon.

[AppVeyorBot]

✅ Download x64dbg 1.0.1883 (commit 833ab6da54 by @torusrxxx)

[torusrxxx]

I'm adding support for tab detaching in new tabbed trace view. Currently there's crashing with certain user action sequences.

[AppVeyorBot]

✅ Download x64dbg 1.0.1887 (commit 45dc8108a2 by @torusrxxx)

[torusrxxx]

Now the dump is disabled, and a "load dump" button appears there. Clicking on the button will load the dump view.
Searching will also load the dump view automatically. This makes future searches faster.
And #3390 is fixed. Now the user can go to a virtual address. If multiple executions of the same virtual address are found, the xrefs dialog is displayed. The search uses the dump index to find all the indices instantly.

[AppVeyorBot]

✅ Download x64dbg 1.0.1889 (commit 8f89bb542c by @torusrxxx)

[AppVeyorBot]

✅ Download x64dbg 1.0.1892 (commit 9b5ba2f485 by @torusrxxx)

[AppVeyorBot]

✅ Download x64dbg 1.0.1893 (commit 4df0db215f by @torusrxxx)