Skip to content

Commit

Permalink
Bug fix: editorDetails.ApplicationVersion wasn't used which causes sc…
Browse files Browse the repository at this point in the history
…hema error (missing mandatory attribute)
  • Loading branch information
martin1cerny committed Oct 24, 2016
1 parent 4aa70c4 commit 80ace8b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Xbim.Cobie.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<package xmlns="http://schemas.microsoft.com/packaging/2011/10/nuspec.xsd">
<metadata>
<id>Xbim.Cobie</id>
<version>4.0.3</version>
<version>4.0.4</version>
<title>xBIM Cobie</title>
<authors>xBIM team</authors>
<owners>Steve Lockley, Martin Cerny</owners>
Expand All @@ -20,7 +20,7 @@
<tags>COBie, BIM, IFC, IfcXml, IfcZip, COBie, Ifc4, .Net, C#, BuildingSmart</tags>
<dependencies>
<dependency id="NPOI" version="2.2.1" />
<dependency id="Xbim.Essentials" version="4.0.3" />
<dependency id="Xbim.Essentials" version="4.0.4" />
</dependencies>
</metadata>
<files>
Expand Down
2 changes: 1 addition & 1 deletion Xbim.Essentials.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<package xmlns="http://schemas.microsoft.com/packaging/2011/10/nuspec.xsd">
<metadata>
<id>Xbim.Essentials</id>
<version>4.0.3</version>
<version>4.0.4</version>
<title>xBIM Essentials</title>
<authors>xBIM Team</authors>
<owners>Steve Lockley, Martin Cerny</owners>
Expand Down
2 changes: 2 additions & 0 deletions Xbim.Ifc/IfcStore.cs
Original file line number Diff line number Diff line change
Expand Up @@ -600,6 +600,7 @@ public IIfcApplication DefaultOwningApplication
a.ApplicationDeveloper = Instances.New<Ifc4.ActorResource.IfcOrganization>(o => o.Name = _editorDetails.ApplicationDevelopersName);
a.ApplicationFullName = _editorDetails.ApplicationFullName;
a.ApplicationIdentifier = _editorDetails.ApplicationIdentifier;
a.Version = _editorDetails.ApplicationVersion;
}
));
return _defaultOwningApplication ??
Expand All @@ -609,6 +610,7 @@ public IIfcApplication DefaultOwningApplication
a.ApplicationDeveloper = Instances.New<Ifc2x3.ActorResource.IfcOrganization>(o => o.Name = _editorDetails.ApplicationDevelopersName);
a.ApplicationFullName = _editorDetails.ApplicationFullName;
a.ApplicationIdentifier = _editorDetails.ApplicationIdentifier;
a.Version = _editorDetails.ApplicationVersion;
}
));
}
Expand Down

2 comments on commit 80ace8b

@XbimCI
Copy link
Contributor

@XbimCI XbimCI commented on 80ace8b Oct 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TeamCity Xbim :: Xbim Essentials :: XbimEssentials Build 449 is now running

@XbimCI
Copy link
Contributor

@XbimCI XbimCI commented on 80ace8b Oct 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TeamCity Xbim :: Xbim Essentials :: XbimEssentials Build 449 outcome was SUCCESS
Summary: Running Build time: 00:02:15

Please sign in to comment.