Tessellation was done in floats, resulting in loss of precision. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blesome in very large projects where units are millimeters.
|
Thank you very much @fomayette , such contribution is highly appreciated. I'm sorry we didn't get earlier to your pull request but we were all around the place working on other projects. Martin |
martin1cerny
added a commit
that referenced
this pull request
Nov 1, 2017
…te in PR #103. This should make xBIM binary compatible with older files. Double precision is kept in Xbim.Tesselator for precision of data transformations. It is only converted to single when serialized into binary.
|
Closing, because back compatibility was solved as mentioned in #115. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tessellation was done in floats, resulting in loss of precision.
Troublesome in very large projects where units are millimeters.
Before :
After :
