Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESENT Windows XP compatibility problem #41

Closed
wants to merge 1 commit into from

Conversation

Artoymyp
Copy link
Contributor

This fixes the ESENT Windows XP compatibility problem mentioned in the issue:
xBimTeam/XbimGeometry#8.
Exception message: Microsoft.Isam.Esent.Interop.EsentTaggedNotNULLException, "No non-NULL tagged columns"

The problem is due to the incorrect combination of a ESE column valueType and a column null-constraint during JetAddColumn as documented here:
https://msdn.microsoft.com/en-us/library/gg294122(v=exchg.10).aspx:
JET_bitColumnNotNULL cannot be used with tagged, Long Value (that is JET_coltypLongBinary and JET_coltypLongText), or SLV columns.

This fixes the ESENT Windows XP compatibility problem mentioned in the issue:
xBimTeam/XbimGeometry#8.
Exception message: Microsoft.Isam.Esent.Interop.EsentTaggedNotNULLException, "No non-NULL tagged columns"

The problem is due to the incorrect combination of a ESE column valueType and a column null-constraint during JetAddColumn as documented here:
https://msdn.microsoft.com/en-us/library/gg294122(v=exchg.10).aspx:
JET_bitColumnNotNULL cannot be used with tagged, Long Value (that is JET_coltypLongBinary and JET_coltypLongText), or SLV columns.
@Artoymyp Artoymyp changed the title Update EsentShapeGeometryCursor.cs ESENT Windows XP compatibility problem Jun 22, 2016
@martin1cerny
Copy link
Member

Hi @Artoymyp , thank you very much for the fix. I've just assigned this request to @SteveLockley who is author of the original implementation to review the impact of this change. Do you actually use WinXP in any kind of production environment?

@Artoymyp
Copy link
Contributor Author

Hello @martin1cerny !
Thank you for your attention. Our users work with a wide range of Windows versions. And yes, we actually still have a significant amount of WinXP users.
The expert opinion of @SteveLockley , concerning the safety of such a fix, would be highly appreciated.

@andyward
Copy link
Member

andyward commented Oct 9, 2019

Closing this. XP is ancient history

@andyward andyward closed this Oct 9, 2019
@Artoymyp
Copy link
Contributor Author

Artoymyp commented Oct 9, 2019

No problem. We have dropped XP support too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants