fix(client) first_connect was not properly updated

mqtt/client.lua

@@ -230,8 +230,9 @@ function client_mt:__init(opts)
 	self._to_remove_handlers = {}
 
 	-- state
-	self.first_connect = true		-- contains true to perform one network connection attemt after client creation
 	self.send_time = 0				-- time of the last network send from client side
+	self.first_connect = true		-- contains true to perform one network connection attempt after client creation
+									-- Note: remains true, during the connect process. False after succes or failure.
 
 	-- packet creation/parse functions according version
 	if not a.version then
@@ -697,12 +698,14 @@ function client_mt:start_connecting()
 	-- open network connection
 	local ok, err = self:open_connection()
 	if not ok then
+		self.first_connect = false
 		return false, err
 	end
 
 	-- send CONNECT packet
 	ok, err = self:send_connect()
 	if not ok then
+		self.first_connect = false
 		return false, err
 	end
 
@@ -972,6 +975,7 @@ function client_mt:handle_received_packet(packet)
 			log:error("client '%s' %s", self.opts.id, err)
 			self:handle("error", err, self)
 			self:close_connection("error")
+			self.first_connect = false
 			return false, err
 		end
 
@@ -985,13 +989,15 @@ function client_mt:handle_received_packet(packet)
 			self:handle("error", err, self, packet)
 			self:handle("connect", packet, self)
 			self:close_connection("connection failed")
+			self.first_connect = false
 			return false, err
 		end
 
 		log:info("client '%s' connected successfully to '%s'", self.opts.id, conn.uri)
 
 		-- fire connect event
 		self:handle("connect", packet, self)
+		self.first_connect = false
 	else
 		-- connection authorized, so process usual packets
 

mqtt/ioloop.lua

@@ -162,7 +162,7 @@ function ioloop_mt:iteration()
 			-- an error from a client was returned
 			if not client.opts.reconnect then
 				-- error and not reconnecting, remove the client
-				log:fatal("client '%s' failed with '%s', will not re-connect", client.opts.id, err)
+				log:info("client '%s' returned '%s', no re-connect set, removing client", client.opts.id, err)
 				self:remove(client)
 				t = opts.sleep_max
 			else

tests/spec/06-mqtt-client_spec.lua

@@ -356,8 +356,10 @@ describe("last will message", function()
 
 		local function send_self_destroy()
 			if not client1_ready or not client2_ready then
+				log:warn("not self destroying, clients not ready")
 				return
 			end
+			log:warn("client1 publishing 'self-destructing-message' to '.../stop' topic")
 			assert(client1:publish{
 				topic = prefix.."/stop",
 				payload = "self-destructing-message",
@@ -367,13 +369,17 @@ describe("last will message", function()
 		client1:on{
 			connect = function()
 				-- subscribe, then send self-destructing message
+				log:warn("client1 is now connected")
+				log:warn("client1 subscribing to '.../stop' topic")
 				assert(client1:subscribe{topic=prefix.."/stop", callback=function()
 					client1_ready = true
+					log:warn("client1 subscription to '.../stop' topic confirmed, client 1 is ready for self destruction")
 					send_self_destroy()
 				end})
 			end,
 			message = function()
 				-- break connection with broker on any message
+				log:warn("client1 received a message and is now closing its connection")
 				client1:close_connection("self-destructed")
 			end,
 		}
@@ -383,13 +389,17 @@ describe("last will message", function()
 		client2:on{
 			connect = function()
 				-- subscribe to will-message topic
+				log:warn("client2 is now connected")
+				log:warn("client2 subscribing to will-topic: '.../willtest' topic")
 				assert(client2:subscribe{topic=will_topic, callback=function()
 					client2_ready = true
+					log:warn("client2 subscription to will-topic '.../willtest' confirmed, client 2 is ready for self destruction")
 					send_self_destroy()
 				end})
 			end,
 			message = function(msg)
 				will_received = msg.topic == will_topic
+				log:warn("client2 received a message, topic is: '%s', client 2 is now closing its connection",tostring(msg.topic))
 				client2:disconnect()
 			end,
 		}