Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to fetch Braavos account #9

Closed
wants to merge 1 commit into from

Conversation

glihm
Copy link
Contributor

@glihm glihm commented Jul 5, 2023

Proposal to add the current Braavos proxy class_hash as a supported accounts.

Braavos allows the user to export his private key, which makes it suitable for fecthing.

This PR considers for now that Braavos is using the OpenZeppelin config. May be changed later if they differ too much.

@milancermak
Copy link

I have code ready to do the same for Argent account v0.2.3. Will send a PR once this is merged.

@glihm
Copy link
Contributor Author

glihm commented Jul 6, 2023

I have code ready to do the same for Argent account v0.2.3. Will send a PR once this is merged.

How did you do to use Argent account as the private key is not extractable?
Or is it now?

@milancermak
Copy link

Wasn't it always the case?

Click the cog icon top-right, then the wallet name button on the top, and then you see a nice red "Export private key" button.

@glihm
Copy link
Contributor Author

glihm commented Jul 6, 2023

Wasn't it always the case?

Click the cog icon top-right, then the wallet name button on the top, and then you see a nice red "Export private key" button.

Wouarg sorry, totally my bad. Don't use it enough. Yup then it would be super nice having your PR. 👍

@milancermak
Copy link

@glihm
Copy link
Contributor Author

glihm commented Aug 3, 2023

Bump @xJonathanLEI. 😁

@dbejarano820
Copy link

I was just asking about this feature!

@xJonathanLEI
Copy link
Owner

Reusing OzAccountConfig is probably not a good idea. Oz and Braavos accounts are different as in one uses proxy and one does not. For the Braavos account we might also want to store the impl hash.

@xJonathanLEI
Copy link
Owner

Superseded by 331173c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants