Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: audit and udeps #16

Merged
merged 4 commits into from
Jan 10, 2022
Merged

ci: audit and udeps #16

merged 4 commits into from
Jan 10, 2022

Conversation

milancermak
Copy link
Collaborator

Adds two new CI Actions, as discussed in #4:

  1. Security audit check via the audit-check action. It is set up to run periodically once a day (as opposed to it being triggered by a push to master on on a PR) because of a limitation that the action can't be triggered if the PR is coming from a fork. I figure it's fine this way because of the release process.

  2. Unused dependencies via cargo-udeps. There's no GH Action wrapper for the tool, so I just built it using action-rs/toolchain, similar to the test workflow. It runs on nightly.

I had a look at cargo-deny as mentioned in #4, but I don't think it's necessary.

@xJonathanLEI
Copy link
Owner

@milancermak Seems to be an issue with YAML format. Try formatting with prettier --write .?

@xJonathanLEI
Copy link
Owner

It's the audit.yml file:

diff --git a/.github/workflows/audit.yml b/.github/workflows/audit.yml
index b029e05..ce4e7e9 100644
--- a/.github/workflows/audit.yml
+++ b/.github/workflows/audit.yml
@@ -1,7 +1,7 @@
 on:
   schedule:
     # 2:20 past midnight UTC
-    - cron: '20 2 * * *'
+    - cron: "20 2 * * *"

 name: Security audit
 jobs:

@milancermak
Copy link
Collaborator Author

Yeah, saw that, fixed now.

Also the udeps is taking way too long, gonna tweak the cache settings so it's faster.

@xJonathanLEI
Copy link
Owner

Yeah installing udeps itself takes really long lol. Not a huge deal though considering GitHub Actions is free for open-source projects (as far as I remember).

@xJonathanLEI
Copy link
Owner

Oops. It seems serde_json is only used in tests in starknet-core. We need to move it to [dev-dependencies].

Copy link
Owner

@xJonathanLEI xJonathanLEI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xJonathanLEI xJonathanLEI merged commit dca4a30 into master Jan 10, 2022
@xJonathanLEI xJonathanLEI deleted the more-ci-actions branch January 10, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants