Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_std compatibility #303

Closed
wants to merge 20 commits into from

Conversation

AbdelStark
Copy link
Contributor

@AbdelStark AbdelStark commented Feb 13, 2023

Description

This PR enables no_std compatibility for starknet-rs.
It uses no-std-compat crate to achieve this goal.

Usage

If you want to use a crate from starknet-rs with no-std support you can do like this:

starknet-crypto = { git = "...", rev = "...", default-features = false }

std = [
  "starknet-crypto/std",
]

@AbdelStark AbdelStark marked this pull request as draft February 14, 2023 08:12
@AbdelStark
Copy link
Contributor Author

Actually it seems we won't be able to use no-std-compat.

We will likely have to handle the compatibility manually, like what Substrate std is doing:
https://github.com/paritytech/substrate/blob/polkadot-v0.9.37/primitives/std/src/lib.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant