PHP 7.1 compatibility: harmonize method signatures #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Apr 29, 2017
src/Api/Cloud.php
Outdated
| @@ -196,7 +196,7 @@ public function getEncodings(array $filter = array()) | |||
| /** | |||
| * {@inheritDoc} | |||
| */ | |||
| public function getEncodingsWithStatus($status, array $filter = array()) | |||
| public function getEncodingsWithStatus($status, array $filter = null) | |||
| { | |||
| $filter['status'] = $status; | |||
There was a problem hiding this comment.
Well, it works (see https://3v4l.org/p1lU1) at least for PHP versions <= 7.1. But I agree that this is not a very clean solution. So I pushed some more code making sure that $filter is an array before modifying it.
|
@xabbuh I suggest you to merge this PR and tag a 1.2.1 release fixing the compat with PHP 7.1, before doing the work of migrating to HTTPlug. |
xabbuh
added a commit
that referenced
this pull request
Apr 30, 2017
This PR was merged into the 1.2.x-dev branch. Discussion ---------- PHP 7.1 compatibility: harmonize method signatures Commits ------- 233e29b PHP 7.1 compatibility: harmonize method signatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.