Fix the CI setup by using simple-phpunit #22
Conversation
This prepares the compatibility with PHPUnit 6, but the dependency for container tests is not yet compatible.
This avoids installing it when running it, which displays the installation logs non-collapsed on Travis
|
As I added a job running on PHP 7.1, it requires merging xabbuh/panda-client#15 too |
| @@ -35,9 +36,10 @@ before_install: | |||
|
|
|||
| install: | |||
| - composer update $COMPOSER_OPTIONS | |||
| - vendor/bin/simple-phpunit install | |||
There was a problem hiding this comment.
See the last commit. This is just to make the Travis output cleaner (having the install steps done in a collapsed section rather than being displayed in the test command itself)
.gitignore
Outdated
| @@ -2,4 +2,4 @@ composer.lock | |||
| Tests/App/log | |||
| Tests/App/cache | |||
| vendor | |||
|
|
|||
| /.phpunit | |||
There was a problem hiding this comment.
This must actually be vendor/symfony/phpunit-bridge/bin/.phpunit, right?
There was a problem hiding this comment.
yeah, too used to the Symfony repo which has a script at the root and so .phpunit ends up at the root (which is far easier to cache on Travis btw).
There was a problem hiding this comment.
fixed. And I kept some caching on Travis.
By default, the phpunit-bridge stores these files inside itself, which is hard to cache on Travis (at least without side-effects on composer itself).
|
OK, ready except for the failure on Symfony 3.3 (the dev build), which I will investigate |
|
The deprecation-related failure on 3.3 is because the ControllerTest is instantiating the kernel and the container like for functional tests, and then tries to inject mocks in it for all the panda-client layer. This is really weird, and requires rewriting the test entirely. So I suggest doing it in a separate PR. |
|
Thank you @stof. |
This PR was squashed before being merged into the 1.2.x-dev branch (closes #22). Discussion ---------- Fix the CI setup by using simple-phpunit Commits ------- 055c0db Force installing the PHPUnit files in a cacheable location d3e6a7d Install PHPUnit during the install step ac33930 Remove the dependency on Yaml in the testsuite f2235d3 Use the namespaced test case from PHPUnit c42ba98 Use simple-phpunit from the bridge rather than the Travis PHPUnit
No description provided.