Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual highlighting graceful fail #189

Closed
ellvix opened this issue Jun 2, 2023 · 9 comments · Fixed by #375
Closed

Visual highlighting graceful fail #189

ellvix opened this issue Jun 2, 2023 · 9 comments · Fixed by #375

Comments

@ellvix
Copy link
Collaborator

ellvix commented Jun 2, 2023

all chart types need to be tested so they gracefully fail if madir.elements is not supplied. Did barchart already but the rest need a look

@yujuny2
Copy link
Contributor

yujuny2 commented Sep 4, 2023

Done with barplot. Summary of how it works:
absent data --> will not work at all
absent x level, data.length != elements.length --> no visual highlighting, warning
absent elements --> no visual highlighting
absent elements, data.length != xlevel.length --> no visual highlighting, warning
absent x level, absent elements --> no visual highlighting

@yujuny2
Copy link
Contributor

yujuny2 commented Sep 6, 2023

update: add warnings for any absent elements

@yujuny2
Copy link
Contributor

yujuny2 commented Sep 10, 2023

For heatmap -- Need to fix display.js as the text won't work with the absence of x level or y level.

@ellvix
Copy link
Collaborator Author

ellvix commented Oct 6, 2023

Addition: Handle 'Fill' for all plots (should work for heatmap if it exists, or "Plot does not have a Fill label" fallback)

@yujuny2
Copy link
Contributor

yujuny2 commented Oct 18, 2023

Heatmap:

  • throw error if 'data' is not defined
  • turn off visual highlight if 'elements' or 'xlevel' or 'ylevel' is absent
  • turn off visual highlight if elements.length != data.length
  • fixed fill label key (L+F)
  • replace x_labels/xlevel, y_labels/ylevel with undefined values if absent

@yujuny2
Copy link
Contributor

yujuny2 commented Oct 18, 2023

Boxplot, lineplot:

  • turn off visual highlight when 'elements' is absent

@yujuny2
Copy link
Contributor

yujuny2 commented Oct 18, 2023

Scatterplot:
turn off visual highlight if type 'point' or 'smooth' exists, and

  • 'elements' does not exist at all
  • 'elements' exists but is empty
  • 'elements' exists but is not an array
  • 'elements' and 'type' do not have the same length

@yujuny2
Copy link
Contributor

yujuny2 commented Oct 18, 2023

Histogram:

  • turn off visual highlight if 'elements' is absent
  • turn off visual highlight if 'elements' and 'data' do not have the same length

Copy link
Contributor

github-actions bot commented Feb 7, 2024

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants