Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scatterplot incompatibility with Matplotlib and when used only with one layer #400

Open
SaaiVenkat opened this issue Feb 13, 2024 · 0 comments
Open

fix: scatterplot incompatibility with Matplotlib and when used only with one layer #400

SaaiVenkat opened this issue Feb 13, 2024 · 0 comments
Assignees
@SaaiVenkat
Labels
bug Something isn't working

Comments

@SaaiVenkat
Copy link
Collaborator

Bug Report

Description

Scatterplot BTS modes doesn't work properly when used only with one layer. Moreover, the SVGs generated from Matplotlib is not compatible with the existing library.

Steps to Reproduce

  1. Step 1 - Generate a scatterplot from Matplotlib with one layer
  2. Step 2 - Create HTML based on step 1
  3. Step 3 - Try navigating through the chart

Actual Behavior

BTS modes doesn't work properly

Expected Behavior

BTS modes should work properly and with any kind of layer configuration

Screenshots

Environment

  • Operating System: Mac OS
  • Browser: Chrome

Additional Information
@SaaiVenkat SaaiVenkat added the bug Something isn't working label Feb 13, 2024
@SaaiVenkat SaaiVenkat self-assigned this Feb 13, 2024
This was referenced Feb 13, 2024
Closed
Merged
jooyoungseo pushed a commit that referenced this issue Feb 16, 2024
@SaaiVenkat
fix(scatterplot): support svg from matplotlib (#406)
6069056 
# Pull Request

## Description
<!-- Provide a brief description of the changes made in this pull
request. -->
- Updated scatterplot to SVG including path elements, which are
generated from Matplotlib/Seaborn

## Related Issues
<!-- Specify any related issues or tickets that this pull request
addresses. -->
- Closes 
  - #400 

## Changes Made
<!-- Describe the specific changes made in this pull request. -->
- Updated scatterplot to handle all kinds of layers along with SVG path
element

## Screenshots (if applicable)
<!-- Include any relevant screenshots or images to help visualize the
changes. -->
<!-- You can take a gif animation screenshot very easily without any
additional installation by using this browser-based tool: -->
<!-- https://gifcap.dev -->

## Checklist
<!-- Please select all applicable options. -->
<!-- To select your options, please put an 'x' in the all boxes that
apply. -->

- [x] I have read the [Contributor Guidelines](../CONTRIBUTING.md).
- [x] I have performed a self-review of my own code and ensured it
follows the project's coding standards.
- [x] I have tested the changes locally following
`ManualTestingProcess.md`, and all tests related to this pull request
pass.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation, if applicable.
- [ ] I have added appropriate unit tests, if applicable.

## Additional Notes
<!-- Add any additional notes or comments here. -->
<!-- Template credit: This pull request template is based on Embedded
Artistry
{https://github.com/embeddedartistry/templates/blob/master/.github/PULL_REQUEST_TEMPLATE.md},
Clowder
{https://github.com/clowder-framework/clowder/blob/develop/.github/PULL_REQUEST_TEMPLATE.md},
and TalAter {https://github.com/TalAter/open-source-templates}
templates. -->
github-actions bot pushed a commit that referenced this issue Feb 17, 2024
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
6337105 
## [2.0.1](v2.0.0...v2.0.1) (2024-02-17)

### Bug Fixes

* **scatterplot:** support svg from matplotlib ([#406](#406)) ([6069056](6069056)), closes [#400](#400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaaiVenkat SaaiVenkat

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SaaiVenkat