Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scatterplot): support svg from matplotlib #2

Closed
wants to merge 21 commits into from

Conversation

SaaiVenkat
Copy link
Owner

Pull Request

Description

  • Updated scatterplot to SVG including path elements, which are generated from Matplotlib/Seaborn

Related Issues

Changes Made

  • Updated scatterplot to handle all kinds of layers along with SVG path element

Screenshots (if applicable)

Checklist

  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code and ensured it follows the project's coding standards.
  • I have tested the changes locally following ManualTestingProcess.md, and all tests related to this pull request pass.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation, if applicable.
  • I have added appropriate unit tests, if applicable.

Additional Notes

ellvix and others added 12 commits February 12, 2024 21:19
# [1.5.0](xability/maidr@v1.4.1...v1.5.0) (2024-02-14)

### Features

* add user preferences to accompany initial prompt for LLM ([xability#401](xability#401)) ([8783b82](xability@8783b82)), closes [xability#396](xability#396)
BREAKING CHANGE: Changed the way data was stored in the menu, first time
you run you'll need to update LLM settings

Fixed xability#388
# Pull Request

## Description
Created the logo for the project.

## Changes Made
Added the jpg and svg file for the logo

closes xability#313
# [2.0.0](xability/maidr@v1.5.0...v2.0.0) (2024-02-15)

### Bug Fixes

* add tabindex attribute to maidrElemn element ([xability#403](xability#403)) ([f51b917](xability@f51b917))

### Features

* Created ability to chat with multiple LLMs at once ([xability#402](xability#402)) ([80aa119](xability@80aa119)), closes [xability#388](xability#388)

### BREAKING CHANGES

* Changed the way data was stored in the menu, first time
you run you'll need to update LLM settings
# Pull Request

## Description
<!-- Provide a brief description of the changes made in this pull request. -->
Created example scatterplot using Python matplotlib

## Related Issues
<!-- Specify any related issues or tickets that this pull request addresses. -->
Closes xability#366 

## Changes Made
<!-- Describe the specific changes made in this pull request. -->
Added example code, SVG plot, maidr JSON, and raw data JSON for a scatterplot created using matplotlib.

## Screenshots (if applicable)
<!-- Include any relevant screenshots or images to help visualize the changes. -->
<!-- You can take a gif animation screenshot very easily without any additional installation by using this browser-based tool: -->
<!-- https://gifcap.dev -->

## Checklist
<!-- Please select all applicable options. -->
<!-- To select your options, please put an 'x' in the all boxes that apply. -->

- [x] I have read the [Contributor Guidelines](../CONTRIBUTING.md).
- [x] I have performed a self-review of my own code and ensured it follows the project's coding standards.
- [x] I have tested the changes locally following `ManualTestingProcess.md`, and all tests related to this pull request pass.
- [x] I have commented my code, particularly in hard-to-understand areas.
- [ ] I have updated the documentation, if applicable.
- [ ] I have added appropriate unit tests, if applicable.

## Additional Notes
<!-- Add any additional notes or comments here. -->
<!-- Template credit: This pull request template is based on Embedded Artistry {https://github.com/embeddedartistry/templates/blob/master/.github/PULL_REQUEST_TEMPLATE.md}, Clowder {https://github.com/clowder-framework/clowder/blob/develop/.github/PULL_REQUEST_TEMPLATE.md}, and TalAter {https://github.com/TalAter/open-source-templates} templates. -->

NOTE:

Since there are many edge cases, the [fix for scatterplot](#2) should be merged soon after merging this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants