Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file regexp pattern in README #813

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

kevinpapst
Copy link
Contributor

@kevinpapst kevinpapst commented Jan 2, 2024

See https://github.com/kimai/kimai/actions/runs/7385039079/job/20089038083

Bildschirmfoto 2024-01-02 um 15 05 12

The pull request has only these files changed: https://github.com/kimai/kimai/pull/4514/files

Bildschirmfoto 2024-01-02 um 15 05 48

The "blocks.html.twig" file triggers here, because I blindly followed the (wrong pattern?) in the README.

The pattern .*.lock should only match files that end on .lock (like symfony.lock, composer.lock, yarn.lock).

For testing: https://regex101.com/r/mTsQJG/1

Maybe we can further improve on my suggestion, as I am not the biggest regex friend 馃榿

The README says

In the example above, files with .example extension won't be allowed to be changed.

But the regex also matches 1example.txt.

So maybe the pattern .*\.example$. is even better?

escape filename regex pattern
@xalvarez xalvarez changed the title file regexp pattern in README Fix file regexp pattern in README Jan 2, 2024
@xalvarez xalvarez added bug Something isn't working and removed bug Something isn't working labels Jan 2, 2024
Copy link
Owner

@xalvarez xalvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, thanks for your contribution!

@xalvarez xalvarez merged commit aba1adb into xalvarez:main Jan 2, 2024
5 checks passed
@kevinpapst
Copy link
Contributor Author

Thanks for your work here @xalvarez 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants