Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix wrong default protocol for homepage #4514

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

simonschaufi
Copy link
Contributor

@simonschaufi simonschaufi commented Dec 29, 2023

Resolves: #4513

Description

The label specifies that when entering a homepage, it will be prefixed with https which does not happen. Instead it will be prefixed with http.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai (see license)

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f0165e) 88.29% compared to head (ef37916) 88.29%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4514      +/-   ##
============================================
- Coverage     88.29%   88.29%   -0.01%     
  Complexity     8741     8741              
============================================
  Files           783      783              
  Lines         29243    29244       +1     
============================================
  Hits          25821    25821              
- Misses         3422     3423       +1     
Files Coverage Δ
src/Form/CustomerEditForm.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@kevinpapst
Copy link
Member

Thanks 👍

Could you also replace this:

<span class="input-group-text">
https://
</span>

with something like

        {% if '://' not in value  %}
        <span class="input-group-text">
            https://
        </span>
        {% endif %}

Which would make it complete.

@kevinpapst kevinpapst added the bug label Jan 1, 2024
@kevinpapst kevinpapst added this to the 3.0 - Planned features milestone Jan 1, 2024
@simonschaufi
Copy link
Contributor Author

simonschaufi commented Jan 2, 2024

Done. Can you please have a look at what's wrong with the lock files check?

@kevinpapst
Copy link
Member

kevinpapst commented Jan 2, 2024

Thank you @simonschaufi 👍

The failure is a broken workflow configuration and unrelated: xalvarez/prevent-file-change-action#813

@kevinpapst kevinpapst merged commit 26a8972 into kimai:main Jan 2, 2024
4 of 5 checks passed
@simonschaufi simonschaufi deleted the issue-4513 branch January 2, 2024 14:25
@kevinpapst kevinpapst removed this from the Planned features milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong default protocol for homepage
2 participants