This repository has been archived by the owner on May 5, 2021. It is now read-only.
Prevent handled events from propagating. #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If events are allowed to propagate, then the signature view will not function correctly inside a scroll view. That is, the scroll view will also receive the events and will therefore scroll.
|
Related to #26 |
|
Is there a reason why the pull request is not being accepted to fix this? |
|
There is no reason at this time other than we are preparing to release v2.0 (hopefully today). Once we have that out, we will assign this issue to a version milestone and merge. |
|
@mattleibow right on! thanks for the great component! extremely useful for commercial apps. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If events are allowed to propagate, then the signature view will not function correctly inside a scroll view. That is, the scroll view will also receive the events and will therefore scroll.
This PR fixes this issue for Android (I am not using this control in iOS so cannot speak to whether something similar is required there).