Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Commit

Permalink
[A] Do not throw error for first param in ScrollTo (#742)
Browse files Browse the repository at this point in the history
  • Loading branch information
pauldipietro authored and rmarinho committed Feb 17, 2017
1 parent caa8882 commit 986c46d
Show file tree
Hide file tree
Showing 3 changed files with 55 additions and 0 deletions.
@@ -0,0 +1,51 @@
using Xamarin.Forms.CustomAttributes;
using Xamarin.Forms.Internals;
using System.Collections.Generic;

#if UITEST
using Xamarin.UITest;
using NUnit.Framework;
#endif

namespace Xamarin.Forms.Controls.Issues
{
[Preserve(AllMembers = true)]
[Issue(IssueTracker.Bugzilla, 41600, "[Android] Invalid item param value for ScrollTo throws an error", PlatformAffected.Android)]
public class Bugzilla41600 : TestContentPage
{
protected override void Init()
{
var items = new List<string>();
for (var i = 0; i <= 30; i++)
items.Add(i.ToString());

var listView = new ListView
{
ItemsSource = items
};
Content = new StackLayout
{
Children =
{
listView,
new Button
{
Text = "Click for ScrollTo (should do nothing)",
Command = new Command(() =>
{
listView.ScrollTo("Hello", ScrollToPosition.Start, true);
})
},
new Button
{
Text = "Click for ScrollTo (should go to 15)",
Command = new Command(() =>
{
listView.ScrollTo(items[15], ScrollToPosition.Start, false);
})
}
}
};
}
}
}
Expand Up @@ -130,6 +130,7 @@
<Compile Include="$(MSBuildThisFileDirectory)Bugzilla41415.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Bugzilla41418.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Bugzilla41424.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Bugzilla41600.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Bugzilla41619.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Bugzilla42069.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Bugzilla42069_Page.xaml.cs">
Expand Down
3 changes: 3 additions & 0 deletions Xamarin.Forms.Platform.Android/Renderers/ListViewRenderer.cs
Expand Up @@ -206,6 +206,9 @@ void OnScrollToRequested(object sender, ScrollToRequestedEventArgs e)
else
{
position = templatedItems.GetGlobalIndexOfItem(scrollArgs.Item);
if (position == -1)
return;

cell = templatedItems[position];
}

Expand Down

0 comments on commit 986c46d

Please sign in to comment.