[Bug] Style with NamedSize

[acaliaro]

Description

I have some Styles in my Stylex.xaml under Xamarin Forms project. When I use this style, I have this string in"output" VisualStudio tab:
[0:] SetValue: Can not convert Xamarin.Forms.OnIdiom`1[Xamarin.Forms.NamedSize] to type 'System.Double'

Steps to Reproduce

1. Create a style with TargetType="Label" and

    <Setter Property="FontSize">
        <Setter.Value>
            <OnIdiom
                x:TypeArguments="NamedSize"
                Phone="Small"
                Tablet="Medium" />
        </Setter.Value>
    </Setter> 
   

Expected Behavior

No message in "output" tab

Actual Behavior

Message in "output" tab

Basic Information

• Version with issue: 4.4.0.991537
• Last known good version: unknown
• IDE: Microsoft Visual Studio Community 2019
  Versione 16.5.0
• Platform Target Frameworks:
  • Android: 9.0

[jfversluis]

If you change NamedSize to x:String does that work? I think the converter should pick it up and do the conversion for you

[acaliaro]

[0:] SetValue: Can not convert Xamarin.Forms.OnIdiom`1[System.String] to type 'System.Double'

[jfversluis]

Looks like something similar was reported in #4319 and fixed, although I only see reference to the markup extension.

Tried it with the markup extension and that works, so as a workaround you should be able to do this:

<Setter Property="FontSize" Value="{OnIdiom Phone=Small, Tablet=Medium}" />

Reproduction showing the issue on iOS and Android is attached

Repro10006.zip

[samhouts]

@acaliaro Since we haven't heard from you in more than 30 days, we hope this issue is no longer affecting you. If it is, please reopen this issue and provide the requested information so that we can look into it further. Thank you!

[samhouts]

Oops, wrong issue. Reopened :)

[acaliaro]

@samhouts I am waiting an answer... I have done a repo but not answers till now... what should I do?

[samhouts]

@acaliaro We verified the bug, and now it's on the backlog. Was the workaround in #10006 (comment) helpful at all? Thanks!

[acaliaro]

I will try the workaround
Thanks

[ronymesquita]

Looks like something similar was reported in #4319 and fixed, although I only see reference to the markup extension.

Tried it with the markup extension and that works, so as a workaround you should be able to do this:

<Setter Property="FontSize" Value="{OnIdiom Phone=Small, Tablet=Medium}" />

Reproduction showing the issue on iOS and Android is attached

Repro10006.zip

This workaround also works on a similar manner with OnPlatform:
<Setter Property="FontSize" Value="{OnPlatform Android=Micro, iOS=Small}" />

The tag OnPlatform didn't work in the normal syntax, like this:

<OnPlatform x:TypeArguments="NamedSize">
    <On Platform="Android" Value="Micro" />
    <On Platform="iOS" Value="Small" />
</OnPlatform>