[Bug-WPF] FontFamily not working for FontAwesome

[tessarolli]

Description

After updating to 4.8, Labels no longer show FontAwesome Icons on WPF Application.
All other Platforms are working as they should.

Steps to Reproduce

<OnPlatform x:Key="FontAwesomeSolid" x:TypeArguments="x:String">
                <On Platform="Android">FontAwesome5_Solid.otf#Regular</On>
                <On Platform="iOS">FontAwesome5Free-Solid</On>
                <On Platform="UWP">/Assets/Fonts/FontAwesome5_Solid.otf#Font Awesome 5 Free</On>
                <On Platform="WPF">pack://application:,,,/Fonts/#Font Awesome 5 Free Solid</On>
            </OnPlatform>

 public static class FASolid
    {
public static string Eraser { get => "\uf12d"; }
}
xmlns:res="clr-namespace:myNameSpace.Resources"
<Label Text="{Static res:FASolid.Eraser}" 
                               FontFamily="{StaticResource FontAwesomeSolid}"
                        </Label>

Expected Behavior

Actual Behavior

Basic Information

• Version with issue: 4.8+
• Last known good version: 4.5

Screenshots

Working (UWP):

Not Working (WPF):

Workaround

Didn't find any, yet..

[rmarinho]

Hi, can you please send us a small reproduction project?

Thanks

[tessarolli]

BugReport.zip

[lindexi]

Why it can not show the right character?

Because the font is pack://application:,,,/Fonts/#Font Awesome 5 Free Solid, Assets/Fonts/pack://application:,,,/Fonts/.ttf#Font Awesome5Free Solid, Assets/Fonts/pack://application:,,,/Fonts/.otf#Font Awesome5Free Solid

[lindexi]

Why it will set this font name?

See

Xamarin.Forms/Xamarin.Forms.Platform.WPF/Extensions/FontExtensions.cs

Lines 120 to 142 in fce7c48

	public static FontFamily ToFontFamily(this string fontFamily, string defaultFontResource = "FontFamilySemiBold")
	{
	if(string.IsNullOrWhiteSpace(fontFamily))
	return (FontFamily)System.Windows.Application.Current.Resources[defaultFontResource];
	if (FontFamilies.TryGetValue(fontFamily, out var f))
	{
	return f;
	}
	var embeddedResult = fontFamily.TryGetFromAssets();
	if (embeddedResult.success)
	return FontFamilies[fontFamily] = embeddedResult.fontFamily;
	//self.FontFamily = new FontFamily(new Uri("pack://application:,,,/"), fontFamily);
	//Cache this puppy!
	var formatted = string.Join(", ", GetAllFontPossibilities(fontFamily));
	var font = new FontFamily(formatted);
	FontFamilies[fontFamily] = font;
	return font;
	}

It will join the all the font: var formatted = string.Join(", ", GetAllFontPossibilities(fontFamily));

[tessarolli]

Why it can not show the right character?

Because the font is pack://application:,,,/Fonts/#Font Awesome 5 Free Solid, Assets/Fonts/pack://application:,,,/Fonts/.ttf#Font Awesome5Free Solid, Assets/Fonts/pack://application:,,,/Fonts/.otf#Font Awesome5Free Solid

I've tried your solution, it did not help.

<On Platform="WPF">pack://application:,,,/Fonts/#Font Awesome 5 Free Solid, Assets/Fonts/pack://application:,,,/Fonts/.ttf#Font Awesome5Free Solid, Assets/Fonts/pack://application:,,,/Fonts/.otf#Font Awesome5Free Solid</On>
I've also tried without the Assets/ on the path.

[lindexi]

@tessarolli I try to fix this in #11977

[DennisWelu]

@samhouts @PureWeen Looks like this is in and out of the priority list for upcoming releases. What's the thought on a future fix? Looks like @lindexi has a PR in and just pending review. If the fix doesn't make it into a 4.8.x SR, as it appears, it will force me to update everything in the solution to 5.x when that is GA (due to other changes like MasterDetailPage name change etc.). Kinda leaves 4.x WPF solutions hanging.

[DennisWelu]

Can someone explain the relationship the 5.0.1 project has to the 5.0.0 SR process? This fix has been Done for quite some time in the 5.0.1 project and hasn't made it to a SR that I'm aware. When is 5.0.1 targeted for?