Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix miss font #11977

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Fix miss font #11977

merged 1 commit into from
Dec 18, 2020

Conversation

lindexi
Copy link
Contributor

@lindexi lindexi commented Sep 1, 2020

Description of Change

We should not re-splice a font file uri

Issues Resolved

API Changes

None

Platforms Affected

  • WPF

Behavioral/Visual Changes

Before the change, the application will display the square, and after the change, the application will display the correct font

Before/After Screenshots

Before Screenshots

After Screenshots:

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Sep 1, 2020
@PureWeen PureWeen added this to In progress in v5.0.1 via automation Nov 5, 2020
@PureWeen PureWeen removed this from In Review in vNext+1 (5.0.0) Nov 5, 2020
@PureWeen PureWeen added this to the 5.0.1 milestone Nov 5, 2020
@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Nov 5, 2020
@PureWeen PureWeen removed this from In Review in vNext+1 (5.0.0) Nov 5, 2020
v5.0.1 automation moved this from In progress to Reviewer approved Dec 2, 2020
@rmarinho rmarinho merged commit 7c590dd into xamarin:5.0.0 Dec 18, 2020
v5.0.1 automation moved this from Reviewer approved to Done Dec 18, 2020
@lindexi lindexi deleted the t/lindexi/wpf_font branch December 18, 2020 11:27
@samhouts samhouts modified the milestones: 5.0.1, 5.0.0 Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

[Bug-WPF] FontFamily not working for FontAwesome
6 participants